Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fix for text improperly wrapping in sidenav #257

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Added fix for text improperly wrapping in sidenav #257

merged 1 commit into from
Jan 16, 2020

Conversation

zttodd
Copy link
Contributor

@zttodd zttodd commented Jan 16, 2020

If the link label was longer than the container, the button would wrap to the next line along with the text.

Screen Shot 2020-01-16 at 11 40 29 AM

This fix adds a div around the rvt-sidenav__link and rvt-sidenav__toggle to contain them to one line and prevent wrapping.

The Sass @each loop was also updated to reflect this new markup structure.

levimcg
levimcg approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@levimcg levimcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, looks great. 💯

@zttodd zttodd merged commit 6d75b17 into 2.0.0-dev Jan 16, 2020
@zttodd zttodd deleted the feature/sidenav-wrap branch January 16, 2020 19:45
@zttodd zttodd mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levimcg levimcg levimcg approved these changes

@illusivesunrae illusivesunrae Awaiting requested review from illusivesunrae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zttodd @levimcg