Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added customEvents to dropdown component #253

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Added customEvents to dropdown component #253

merged 2 commits into from
Jan 10, 2020

Conversation

zttodd
Copy link
Contributor

@zttodd zttodd commented Jan 10, 2020

In this PR:

  • Added dropdownOpen and dropdownClose customEvents
  • Added logic for open() and close() to execute on only one targeted dropdown at a time. This will prevent close() from getting fired multiple times on dropdowns that are already closed.
  • Refactored logic for the esc keyboard functionality

@zttodd zttodd requested a review from levimcg January 10, 2020 19:25
levimcg
levimcg approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@levimcg levimcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice job! 💯

@zttodd zttodd merged commit 98ce0bd into 2.0.0-dev Jan 10, 2020
@zttodd zttodd deleted the feature/dropdown-event branch January 10, 2020 21:00
@zttodd zttodd mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levimcg levimcg levimcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zttodd @levimcg