Deprecated bp() Sass function in favor of $breakpoint variables #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levimcg
approved these changes
May 22, 2019
There was a problem hiding this comment.
This looks great. Thanks for jumping on it so quick! Approving here with one quick ask. Could you add a DEPRECATED note to the bp() function in the _tools.scss file? Just a quick note saying that it will go away in v2 and to use the $breakpoint-* variables instead. Thanks! 🙌
levimcg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces remaining instances of the
bp()Sass function with the appropriate$breakpoint-*variable. This should help make the Sass easier to read.Fixes #115