Add Release Script #358
Add Release Script #358
Conversation
- Generates grpcwebproxy binaries for win, mac, and linux - Uses `github-release` binary to do what it says on the tin and attach the grpcwebproxy binaries to the release - Uses `lerna publish` to publish the client packages to npm
jonny-improbable
force-pushed
the
feature/release-script
branch
from
dd9de27 to
d56a27d
Compare
|
As an alternative to this, have you looked at configuring some GitHub actions? We can use actions for both of these steps I think. |
- Remove quotes from around bash glob as the github-release script will not expand globs.
| echo "Publishing $TAG" | ||
|
|
||
| # Create github release and attach server binaries | ||
| ./node_modules/.bin/github-release upload \ |
There was a problem hiding this comment.
Can we rely on this being installed automatically by Travis?
There was a problem hiding this comment.
Are you referring to github-release? I've added it to the project's list of npm dependencies.
There was a problem hiding this comment.
Yeah, I just don't understand how travis works, I don't think we're checking in ./node_modules/, does travis guarantee that it will run npm install before any script or something?
There was a problem hiding this comment.
I believe so, however given our current flakey tests I am concerned that the publish step will never be reached as the test test that proceeds it will likely fail.
You mentioned using Github Actions as an alternative - these are new to me, let me take a look.
- Fix hard-coded version strings in binary filenames - Rename "build" folder to "dist"
|
To add to my previous comment about github actions: https://sosedoff.com/2019/02/12/go-github-actions.html. |
|
Would be nice to have 0.9.1 for #359 btw. |
|
bump |
|
Thanks for the bump @johanbrandhorst; just checked in with our eng-velocity team who are happy for me to go ahead and investigate github actions. I've taken the first step and signed up for the beta. |
We're going to try out github actions instead!
|
Took the executive decision to merge this as-is. Github never got back to me with with regards to adding us to the Github Hooks Beta, but seeing as I need to cut a release today, I'm going to invoke this script on my machine to at-least automate most of the process. |
github-releasebinary to do what it says on the tin and attach the grpcwebproxy binaries to the releaselerna publishto publish the client packages to npmTODO