Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The method of adding a list keys does not add time expiration for keys #288

Closed
DobrovAlexey opened this issue Jun 30, 2020 · 4 comments
Closed

Comments

@DobrovAlexey
Copy link

Hi,

I found an bug related to the key expiration time when adding a list of keys using AddAllAsync method, but I mistakenly addressed a question to SE.Redis, now I understand that the problem is in the StackExchange.Redis.Extensions packages.

In order not to duplicate the question, I leave a link to the description of the problem:
The method of adding a list does not add time expiration for keys (AddAllAsync) #1514

Thanks.

@imperugo
Copy link
Owner

@imperugo imperugo self-assigned this Jun 30, 2020
@DobrovAlexey
Copy link
Author

DobrovAlexey commented Jul 1, 2020

Hi @DobrovAlexey
looking here /~https://github.com/imperugo/StackExchange.Redis.Extensions/blob/master/src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisDatabase.cs#L224 it seems ok to me.

Do you have a unit test that reproduces the problem?

Hi, yes, I looked the implementation, everything is quite simple there
I added a unit test for this problem, looking here TestAddingListKeys

In the AddManyListKeys method, when adding a second list of keys, they are added with expiration time TTL = -1.
If the test succeeds, I run it several times in a row.

Perhaps this has something to do with Redis itself?
Or am I doing something wrong?

@imperugo imperugo added the bug label Jul 3, 2020
@imperugo
Copy link
Owner

imperugo commented Jul 3, 2020

Hi @DobrovAlexey
thanks for the report. Just send an updated on nuget with the fix.

The release is the 6.3.1

.u

@imperugo imperugo added the Fixed label Jul 3, 2020
DobrovAlexey added a commit to DobrovAlexey/CacheRedisNetCore that referenced this issue Jul 6, 2020
@DobrovAlexey
Copy link
Author

Hi @imperugo,
After updating the packages everything works.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants