analyze: more def list options #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahomescu
approved these changes
Dec 3, 2024
spernsteiner
force-pushed
the
analyze-more-def-list-options-base
branch
from
738692d to
ff0fe1a
Compare
spernsteiner
force-pushed
the
analyze-more-def-list-options
branch
from
34be8b4 to
5073cc4
Compare
spernsteiner
changed the base branch from
analyze-more-def-list-options-base
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more command line options for controlling which defs get rewritten. Specifically, it adds two new options:
--force-rewrite-defs-list FILE: Reads fromFILEa list ofDefIds that should always be rewritten, even if related defs encounter analysis or rewriting errors.--skip-pointee-defs-list FILE: Reads fromFILEa list ofDefIds for which pointee analysis should be skipped.Both options take input in the same format as the existing
--fixed-defs-list FILEoption.These options were useful for getting the
buffermodule to rewrite successfully while runningc2rust-analyzeagainst the entire lighttpd codebase.This PR also fixes a bug that caused
DefIds to be erroneously rejected when parsing the--fixed-defs-listfile.