Fix Darwin CI #1146
Merged
Fix Darwin CI #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was breaking CI because newer macOS seems to ship a clang that is stricter about this
fw-immunant
force-pushed
the
fw/tests-explicit-type
branch
from
5d58c03 to
2a5a361
Compare
also needed for Darwin CI
fw-immunant
force-pushed
the
fw/tests-explicit-type
branch
from
2a5a361 to
ef77378
Compare
|
This fixes CI; it also adds explicit casts, so if the purpose of this test coverage was to handle implicit casts then we should instead take the approach of adding |
thedataking
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darwin CI has been failing on all recent PRs; hopefully this fixes it.