Tweak settings sidebar to make it more consistent with previous design #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low-batt
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
I tested on a MacBook Air running macOS 10.15.7 and my MacBook Pro running macOS 13.6.3. I checked all of the tabs and the layout looked good to me.
This is what it looks like under macOS 10.15.7, with the top panel running the PR and the bottom panel running 1.3.4:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit:
A remake of #4292. This time, I subclassed
NSTableCellViewto manipulate the constraint. The constraint in xib is changed to 0, revert back to 20 on 10.15- systems.@low-batt Please help to test this on 10.15 machine if you still have one :)