Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrubbing preview in timeline rotated #2442

Closed
jrz opened this issue May 4, 2019 · 1 comment
Closed

Scrubbing preview in timeline rotated #2442

jrz opened this issue May 4, 2019 · 1 comment
Labels
progress: fixed/implemented type: enhancement

Comments

@jrz
Copy link

jrz commented May 4, 2019

When playing a rotated video (taken by an iphone), playback is good.
But the preview above the scrubbing timeline does not take into account the video rotation.

1.0.3 Build 106
@uiryuu
Copy link
Member

uiryuu commented May 5, 2019

The preview images are got from FFmpeg, not from mpv, so all the video filters are not going to work. We will try to see whether we can improve this.

uiryuu added a commit that referenced this issue Jul 2, 2020
@uiryuu
Make the thumbnails respect the video rotation
d694a9b 
Ref: #3015, #2817, #2442
lhc70000 added a commit that referenced this issue Aug 25, 2020
@lhc70000
Squashed commit of the following:
67a7636 
commit a2b467bd599eda0e92b9fc5a8aa3b91abedf2d94
Author: Yuze Jiang <fortissimoX@gmail.com>
Date:   Fri Jul 3 21:06:03 2020 +0800

    Cache rotation to improve performence

commit d4e857baa82c0936e352ced78a45095f89de7073
Author: Yuze Jiang <fortissimoX@gmail.com>
Date:   Fri Jul 3 01:10:14 2020 +0800

    Make the thumbnails respect the video rotation

    Ref: #3015, #2817, #2442
0111b pushed a commit to 0111b/iina that referenced this issue Nov 7, 2020
@lhc70000 @0111b
Squashed commit of the following:
1a3faf5 
commit a2b467bd599eda0e92b9fc5a8aa3b91abedf2d94
Author: Yuze Jiang <fortissimoX@gmail.com>
Date:   Fri Jul 3 21:06:03 2020 +0800

    Cache rotation to improve performence

commit d4e857baa82c0936e352ced78a45095f89de7073
Author: Yuze Jiang <fortissimoX@gmail.com>
Date:   Fri Jul 3 01:10:14 2020 +0800

    Make the thumbnails respect the video rotation

    Ref: iina#3015, iina#2817, iina#2442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
progress: fixed/implemented type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrz @lhc70000 @uiryuu