Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): add functions to get OUTPUT parameters #68

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

cesarcoatl
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The only function that attempts to get OUTPUT parameters is get_out_params.

Issue Number: N/A

What is the new behavior?

We have added two new functions that will also retrieve OUTPUT params along with the number of affected rows(1), or a Dataset(2):

  1. o_execute_non_query
  2. o_get_data

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

* o_execute_non_query
* o_get_data
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 2, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.52%.

Quality metrics Before After Change
Complexity 4.43 ⭐ 4.06 ⭐ -0.37 👍
Method Length 42.35 ⭐ 43.05 ⭐ 0.70 👎
Working memory 7.92 🙂 7.90 🙂 -0.02 👍
Quality 75.75% 76.27% 0.52% 👍
Other metrics Before After Change
Lines 362 435 73
Changed files Quality Before Quality After Quality Change
src/incendium/db.py 75.75% ⭐ 76.27% ⭐ 0.52% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/incendium/db.py _execute_sp 14 🙂 170 😞 16 ⛔ 38.70% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@cesarcoatl cesarcoatl added the enhancement New feature or request label Sep 2, 2022
@cesarcoatl cesarcoatl added this to the v2022.9.0 milestone Sep 2, 2022
@cesarcoatl cesarcoatl merged commit c4c4fb4 into code Sep 2, 2022
@cesarcoatl cesarcoatl deleted the feat/db/stored-procedures-with-output branch September 2, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant