Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert #4755 #4874

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Invert #4755 #4874

merged 1 commit into from
Mar 9, 2022

Conversation

bryanph
Copy link
Contributor

@bryanph bryanph commented Mar 8, 2022

Description
As I described in #4755 it doesn't really solve the underlying problem and causes new issues to arise. The code has also has no indication about what it tries to fix. So we should be looking for a better fix that doesn't have side effects.

Issue
Fixes: (link to issue)

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2022

⚠️ No Changeset found

Latest commit: 8191a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bryanph bryanph changed the title Invert /~https://github.com/ianstormtaylor/slate/pull/4755 Invert #4755 Mar 8, 2022
@dylans dylans merged commit 4d28948 into ianstormtaylor:main Mar 9, 2022
@dylans dylans mentioned this pull request Mar 9, 2022
Merged
@adri1wald adri1wald mentioned this pull request Mar 31, 2022
Merged
5 tasks
DougReeder pushed a commit to DougReeder/slate that referenced this pull request Apr 3, 2022
@bryanph @DougReeder
Invert ianstormtaylor#4755 (ianstormtaylor#4874)
88cf45e
e1himself added a commit to e1himself/slate that referenced this pull request Sep 14, 2023
@e1himself
Drop a leftover useRef() call
26b448b 
It was first introduced in ianstormtaylor#4819
but then the usage of this ref was removed with ianstormtaylor#4874

So the ref remained unused since then.
@e1himself e1himself mentioned this pull request Sep 14, 2023
Merged
5 tasks
dylans pushed a commit that referenced this pull request Sep 18, 2023
@e1himself
Drop a leftover useRef() call (#5510)
13c7d27 
* Drop a leftover `useRef()` call

It was first introduced in #4819
but then the usage of this ref was removed with #4874

So the ref remained unused since then.

* Add a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanph @dylans