Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change expected number of CRS to 11975 in GeoServices.test.ts #7447

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

nick4598
Copy link
Contributor

@nick4598 nick4598 commented Dec 4, 2024

image
Arun mentioned that gcs workspace was deployed to prod yesterday.

@nick4598 nick4598 requested a review from a team as a code owner December 4, 2024 20:01
@aruniverse
Copy link
Member

@wgoehrig this seems pretty fragile no?

The gcs workspace doesnt get updated often, but it theoretically could.
Should we rather just expect the gcs workspace to not be empty?

@nick4598 nick4598 requested a review from a team as a code owner December 4, 2024 20:15
@nick4598 nick4598 enabled auto-merge (squash) December 5, 2024 18:20
@nick4598 nick4598 disabled auto-merge December 5, 2024 18:22
@nick4598 nick4598 enabled auto-merge (squash) December 5, 2024 18:34
@nick4598 nick4598 merged commit 84d5a99 into master Dec 5, 2024
16 checks passed
@nick4598 nick4598 deleted the nick/updatecrscount branch December 5, 2024 18:35
@wgoehrig
Copy link
Member

wgoehrig commented Dec 5, 2024

@aruniverse I actually really like this test, I just think we should move it to run as part of the workspace deployment...

@aruniverse
Copy link
Member

@Mergifyio backport release/4.11.x

Copy link
Contributor

mergify bot commented Dec 5, 2024

backport release/4.11.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 5, 2024
aruniverse pushed a commit that referenced this pull request Dec 5, 2024
#7447) [release/4.11.x] (#7451)

Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
@ben-polinsky
Copy link
Contributor

@Mergifyio backport release/4.10.x

Copy link
Contributor

mergify bot commented Dec 17, 2024

backport release/4.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 17, 2024
pmconne pushed a commit that referenced this pull request Dec 17, 2024
#7447) [release/4.10.x] (#7495)

Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants