-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presentation: Fix enum values formatting #7345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigasp
changed the title
[Presentation-common]: enum formating fix
Presentation: Fix enum values formatting
Nov 12, 2024
grigasp
requested changes
Nov 12, 2024
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
MartynasStrazdas
requested review from
christophermlawson,
hl662 and
JonasDov
November 12, 2024 10:56
grigasp
reviewed
Nov 12, 2024
common/changes/@itwin/presentation-common/mast-enum-formating-fix_2024-11-12-10-54.json
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
…fix_2024-11-12-10-54.json Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…winjs-core into mast/enum-formating-fix
grigasp
reviewed
Nov 12, 2024
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/content/PropertyValueFormatter.ts
Outdated
Show resolved
Hide resolved
…winjs-core into mast/enum-formating-fix
grigasp
approved these changes
Nov 12, 2024
@Mergifyio backport release/4.10.x |
✅ Backports have been created
|
@Mergifyio backport release/4.11.x |
✅ Backports have been created
|
@Mergifyio backport release/4.10.x release/4.11.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> (cherry picked from commit 7749869)
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> (cherry picked from commit 7749869)
This was referenced Nov 13, 2024
grigasp
pushed a commit
that referenced
this pull request
Nov 13, 2024
…11.x] (#7358) Co-authored-by: Martynas <43886789+MartynasStrazdas@users.noreply.github.com>
grigasp
pushed a commit
that referenced
this pull request
Nov 13, 2024
…10.x] (#7359) Co-authored-by: Martynas <43886789+MartynasStrazdas@users.noreply.github.com> Co-authored-by: Ben Polinsky <78756012+ben-polinsky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes iTwin/presentation#763