Fix ArcGIS Feature request failures on specific server #7295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdastous-bentley
requested review from
a team,
aruniverse and
eringram
as code owners
aruniverse
reviewed
Oct 25, 2024
extensions/map-layers-formats/src/ArcGisFeature/ArcGisFeatureProvider.ts
Show resolved
Hide resolved
aruniverse
approved these changes
Oct 25, 2024
tcobbs-bentley
approved these changes
Oct 25, 2024
|
@Mergifyio backport release/4.9.x |
✅ Backports have been created
|
eringram
approved these changes
Oct 28, 2024
|
@aruniverse Looks like Im getting random test failures ? |
Yes integration tests are failing due to some auth issues, we are aware and looking into it |
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit 544bc8e)
mdastous-bentley
added a commit
that referenced
this pull request
Oct 31, 2024
… [release/4.9.x] (#7305) Co-authored-by: Michel D'Astous <mdastous-bentley@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves 2 issues:
Capabilities parsing issue of the
supportedQueryFormats:Typically, the capabilities response contains the following:
"supportedQueryFormats": "JSON, PBF",Turns out some server, do no include a whitespace after the comma separator, like this:
"supportedQueryFormats": "JSON,PBF",The
f(i.e. format) query parameter, must have its value set in lower case, even though thesupportedQueryFormatscapability indicates the formats in upper case.This is confirmed by the ArcGIS documentation: