Fix async worker return type #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconne
requested review from
bbastings,
aruniverse,
ben-polinsky and
a team
as code owners
aruniverse
approved these changes
Oct 9, 2024
|
@aruniverse I would like to get it backported to 4.9.x |
|
@Mergifyio backport release/4.9.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
(cherry picked from commit e8139a9)
pmconne
added a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7248.
#7088 enabled support for asynchronous implementations of individual worker operations, to prevent long-running operations from blocking subsequent requests. But, the types did not accurately capture these semantics, so you couldn't return
{ result: T, transfer: Transferable[] }from async implementations without the compiler complaining. It would expect you to return{ result: Promise<T>, transfer: Transferable[] }instead.Adjusted the types to fix this.