Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gather-docs yaml to correct branch name #6579

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

anmolshres98
Copy link
Contributor

This step has been automated here: /~https://github.com/iTwin/itwinjs-core/blob/17656436e63ba98e1d413acd251676f18caf4002/.github/workflows/automation-scripts/update-changelogs.mjs#L96C1-L96C36

However, this automation is done when the finalize release script runs after a minor release. The scripts checks for the most recent commit message to verify it is a minor release then does this change. During this minor release, this check failed because when the finalize release step ran, there was already a commit made after the minor release commit. Hence, the part of the script that does this edit also did not run and now needs to be done manually for this minor.

Minors releases in the future shouldn't need this

@anmolshres98
Copy link
Contributor Author

@DanRod1999 @hl662

@mergify mergify bot requested a review from a team April 3, 2024 16:28
@anmolshres98 anmolshres98 merged commit b67d943 into release/4.5.x Apr 3, 2024
15 checks passed
@anmolshres98 anmolshres98 deleted the as/update-gather-docs branch April 3, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants