Replace use of recursive-readdir package with local implementation #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbjordan
requested review from
a team,
calebmshafer and
wgoehrig
as code owners
raplemie
approved these changes
Oct 24, 2022
kabentley
suggested changes
Oct 24, 2022
kabentley
reviewed
Oct 24, 2022
yes it will. @Mergifyio backport release/3.4.x |
kabentley
approved these changes
Oct 24, 2022
aruniverse
reviewed
Oct 24, 2022
|
@Mergifyio backport release/3.4.x |
✅ Backports have been created
|
aruniverse
approved these changes
Oct 24, 2022
wgoehrig
approved these changes
Oct 24, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
…4537) * remove and reimplement recursive-readdir package * remove minimatch dependency * don't add unused package to browser approved package list * rush change * change var to const/let and remove unecessary comments * remove unnecessary comment * rename readdir export * fix function import Co-authored-by: Matthew Jordan <14913576+mattbjordan@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com> (cherry picked from commit 7ca2709) # Conflicts: # common/config/rush/pnpm-lock.yaml
|
@mattbjordan can you backport to release/2.19.x please? |
|
@mattbjordan nvm. |
mattbjordan
added a commit
that referenced
this pull request
Oct 25, 2022
…4537) * remove and reimplement recursive-readdir package * remove minimatch dependency * don't add unused package to browser approved package list * rush change * change var to const/let and remove unecessary comments * remove unnecessary comment * rename readdir export * fix function import Co-authored-by: Matthew Jordan <14913576+mattbjordan@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4524
recursive-readdirneeds to update it'sminimatchdependency version to fix a security vulnerability issue. Since the last update to this package was 3 years ago and there has been an outstanding PR to upgrade the minimatch version since May with no response from the maintainer...I adapted
recursive-readdir's code (<100 lines) into a single file in our build tools, removed the dependency onminimatchfrom it since it is not needed by us, and accredited the author and licensing accordingly. Please let me know if you think the accreditation needs modification.