Ignore sigpipe to prevent SIGPIPE in CloudSQLite which crashes the process #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick4598
requested review from
pmconne,
khanaffan,
calebmshafer and
bbastings
as code owners
nick4598
changed the title
khanaffan
approved these changes
Dec 20, 2024
|
@Mergifyio backport release/4.10.x |
✅ Backports have been created
|
nick4598
pushed a commit
that referenced
this pull request
Jan 3, 2025
…ocess (#944) (#949) (#950) * ignore sigpipe: no idea if this is the appropriate place to do it * update comment (cherry picked from commit 3574f5b) Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com> (cherry picked from commit 317de9c) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of years ago we added Curlopt_nosignal to the requests sent by cloudsqlite (See forum post for more details. Shortly after we had SQLite team ignore SIGPIPE in the daemon because we were experiencing 141 exit codes in the daemon. 141 exit code is SIGPIPE.
Recently the hub team has been experiencing 141 exits in their v2 checkpoint creation job see ticket I created on their behalf.
SQLite team suggests signal(Sigpipe, sig_ign), so I've copied the way he did it in this commit.
No idea why we are suddenly experiencing this. Would appreciate any feedback on the appropriate place to put this line of code.