Fix regression caused by ClassId conversion to class name vs hexid #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanaffan
requested review from
pmconne,
calebmshafer,
bbastings,
rschili and
ColinKerr
as code owners
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rschili
approved these changes
Oct 7, 2024
nick4598
reviewed
Oct 7, 2024
iModelJsNodeAddon/api_package/ts/src/test/ECSqlStatement.test.ts
Outdated
Show resolved
Hide resolved
…iTwin/imodel-native into affanK/fix-classid-to-json-rule
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Mergifyio backport release/4.9.x |
✅ Backports have been created
|
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@pmconne mind reviewing this? latest pipeline run should succeed any min now |
Waiting for resolution of questions raised on itwinjs-core PR. |
pmconne
approved these changes
Oct 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
) * Fix regression caused by ClassId conversion to class name. * fix typo * Remove unused var * remove only() --------- Co-authored-by: Affan Khan <khanaffan@users.noreply.github.com> (cherry picked from commit 286dc56)
aruniverse
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ackport #878) [release/4.9.x] (#879) * Fix regression caused by ClassId conversion to class name. * fix typo * Remove unused var * remove only() --------- Co-authored-by: Affan Khan <khanaffan@users.noreply.github.com> (cherry picked from commit 286dc56) Co-authored-by: affank <khanaffan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itwinjs-core: iTwin/itwinjs-core#7238