Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecma script 2016 #932

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Ecma script 2016 #932

merged 2 commits into from
Dec 4, 2018

Conversation

gchoqueux
Copy link
Contributor

up to Ecma script 2016

@gchoqueux gchoqueux added this to the 2.6.0 milestone Nov 27, 2018
@zarov
Copy link
Contributor

zarov commented Dec 3, 2018

Beside ** and includes, could you provide a list of things we could update ?

@gchoqueux gchoqueux mentioned this pull request Dec 3, 2018
Closed
43 tasks
@gchoqueux
Copy link
Contributor Author

@zarov see #943

@gchoqueux gchoqueux requested a review from zarov December 3, 2018 15:41
zarov
zarov approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@zarov zarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot some places:

  • Array.prototype.indexOf in View
  • Math.pow in PlanarLayer

Otherwise it's good

@gchoqueux
Copy link
Contributor Author

@zarov thanks.
I don't remove indexOf in view because index is used to splice.

@gchoqueux gchoqueux merged commit d0405a5 into iTowns:master Dec 4, 2018
@gchoqueux gchoqueux deleted the ECMAScript_2016 branch December 4, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarov zarov zarov approved these changes

Assignees
No one assigned
Labels
chore 🚚
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gchoqueux @zarov