Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(src) MSXML2.XMLHTTP.3.0 only use ActiveXObject #260

Merged
merged 1 commit into from
Jun 5, 2017
Merged

fix(src) MSXML2.XMLHTTP.3.0 only use ActiveXObject #260

merged 1 commit into from
Jun 5, 2017

Conversation

9renpoto
Copy link
Contributor

@9renpoto 9renpoto commented Jun 5, 2017 •
edited
Loading

Error

An error occurs when using jsdom and sinonjs.

  • TypeError: Cannot create property 'logger' on string 'MSXML2.XMLHTTP.3.0'
import { useFakeXMLHttpRequest } from 'sinon'
global.XMLHttpRequest = useFakeXMLHttpRequest()

related issue:

@jamuhl jamuhl merged commit de7498d into i18next:master Jun 5, 2017
@jamuhl
Copy link
Member

jamuhl commented Jun 5, 2017

published in i18next-xhr-backend@1.4.2

thank you for providing the PR

@9renpoto 9renpoto deleted the fix/xhr-args branch June 5, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9renpoto @jamuhl