Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve network error detection across browsers #152

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Improve network error detection across browsers #152

merged 2 commits into from
Oct 3, 2024

Conversation

nycruslan
Copy link
Contributor

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

This PR fixes a bug in the error handling logic.

  • Improved network error detection across different browsers.
  • Added checks for specific error messages and TypeError instances.

Fixes #151

@adrai adrai merged commit 7f8e846 into i18next:master Oct 3, 2024
2 checks passed
@adrai
Copy link
Member

adrai commented Oct 3, 2024

included in v2.6.2

@adrai adrai mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent Error Handling Across Browsers for Network Failures
2 participants
@nycruslan @adrai