This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Fix gomod2nix deps; housekeeping #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It failed with "cannot query module due to -mod=vendor" while/after looking for cobra Some trial and error revealed it was just a problem with the gomod2nix being outdated
nix run takes the name of the derivation by default As the binary is called hyprkeys, not Hyprkeys it was necessary to use 'nix shell .# -c hyprkeys'
|
I was not sure which platforms are actually supported but maybe they can also be added to the metadata (as well as the maintainer(s?)) |
|
I must admit I haven't given the nix builds the love they deserve, was meaning to rewrite the flake with flake-parts but seeing how much I lack free time I'll go ahead and merge this for now. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies gomod2nix tried to use deviated from the actual ones after the switch to cobra.
This PR updates the
gomod2nix.toml.I also went ahead and added some metadata to the package.
It should now be possible to be run with
nix run(when in the repo) ornix run github:hyprland-community/Hyprkeys.