Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logfmt escaping #594

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Fix Logfmt escaping #594

merged 5 commits into from
Feb 7, 2024

Conversation

hynek
Copy link
Owner

@hynek hynek commented Feb 5, 2024

Fixes #511, closes #513

@davellas and @madjar – how does this look?

@hynek hynek changed the title Logfmt escaping Fix Logfmt escaping Feb 5, 2024
Copy link
Contributor

@madjar madjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked one of the test cases as not correct. (Checked in loki)

hynek and others added 2 commits February 6, 2024 14:05
Co-authored-by: Georges Dubus <georges.dubus@gmail.com>
@hynek
Copy link
Owner Author

hynek commented Feb 6, 2024

Are we there now? 😅

Copy link
Contributor

@madjar madjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks like what we discussed.

Yay!

@hynek hynek merged commit 354ef53 into main Feb 7, 2024
16 checks passed
@hynek hynek deleted the logfmt-escaping branch February 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogfmtRenderer has a bug with escaped double quotes
2 participants