Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't leak our Python #18

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Don't leak our Python #18

merged 3 commits into from
Oct 10, 2022

Conversation

hynek
Copy link
Owner

@hynek hynek commented Oct 10, 2022

Is this what you meant @henryiii?

Or should I remove the venv wholesale?

@henryiii
Copy link
Contributor

Yes, that's what I meant. 👍

henryiii
henryiii reviewed Oct 10, 2022
View reviewed changes
henryiii
henryiii approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hynek hynek merged commit 360dd1c into main Oct 10, 2022
@hynek hynek deleted the isolate-venv branch October 10, 2022 13:59
@hynek
Copy link
Owner Author

hynek commented Oct 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hynek @henryiii