Fix type hints pickling in python 3.6 #818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type hints can't be properly pickled in python 3.6. This was causing errors the
run_mlm.py
script fromtransformers
with python 3.6However Cloupickle proposed a fix to make it work anyway.
The idea is just to implement the pickling/unpickling of parameterized type hints. There is one detail though: since in python 3.6 we can't use
isinstance
on type hints, then we can't use pickle saving functions registry directly. Therefore we just wrap thesave_global
method of the Pickler.This should fix huggingface/transformers#8212 for python 3.6 and make
run_mlm.py
support python 3.6cc @sgugger