Use full released xsum dataset #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
reviewed
Oct 23, 2020
There was a problem hiding this comment.
Thank you for updating xsum to get the IDS ! Also it looks like it also includes samples that were missing.
I left a few comments that should help you make the CI pass.
Moreover could you increase the dataset VERSION field ?
And remove the SUPPORTED_VERSIONS one that is not supported anyways.
|
@lhoestq I took a shot at addressing your comments but the build scripts seem to be complaining about not being able to open dummy files. How do I resolve those errors without copying the full dataset into the dummy dir? |
|
Could you check that the names of the dummy data files are right ? to print the expected file names |
|
Ok @lhoestq looks like I got the tests to pass :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#672 Fix xsum to expand coverage and include IDs
Code based on parser from older version of
datasets/xsum/xsum.py@lhoestq