Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mirror for RT dataset #484

Merged
merged 3 commits into from
Aug 24, 2020
Merged

update mirror for RT dataset #484

merged 3 commits into from
Aug 24, 2020

Conversation

jxmorris12
Copy link
Contributor

No description provided.

@jxmorris12 jxmorris12 mentioned this pull request Aug 7, 2020
Closed
@lhoestq
Copy link
Member

lhoestq commented Aug 11, 2020

Thanks for adding this mirror link :)

Could you run the following command to update the json file dataset_infos.json used to verify the integrity of the downloaded file ?

nlp-cli test ./datasets/rotten_tomatoes --save_infos --ignore_verifications

@jxmorris12
Copy link
Contributor Author

done! @lhoestq

lhoestq
lhoestq approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@lhoestq
Copy link
Member

lhoestq commented Aug 12, 2020

the build_doc CI fail comes from master and has been fixed on master

thomwolf
thomwolf approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you want to rebase before merge to fix the CI error @jxmorris12?

@jxmorris12
Copy link
Contributor Author

done @thomwolf @lhoestq

@lhoestq lhoestq merged commit c1c6895 into huggingface:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

@thomwolf thomwolf thomwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jxmorris12 @lhoestq @thomwolf