Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add web_questions #401

Merged
merged 2 commits into from
Aug 6, 2020
Merged

add web_questions #401

merged 2 commits into from
Aug 6, 2020

Conversation

mariamabarham
Copy link
Contributor

@mariamabarham mariamabarham commented Jul 16, 2020

add Web Question dataset
#336

Maybe @patrickvonplaten you can help with the dummy_data structure? it still broken

@lhoestq
Copy link
Member

lhoestq commented Jul 21, 2020

What does the nlp-cli dummy_data command returns ?

@patrickvonplaten
Copy link
Contributor

test.json -> test
and
train.json -> train

as shown by the nlp-cli dummy_data command ;-)

@patrickvonplaten
Copy link
Contributor

LGTM for merge @lhoestq - I let you merge if you want to.

@mariamabarham mariamabarham merged commit 38eb241 into master Aug 6, 2020
@mariamabarham mariamabarham deleted the web_questions branch August 6, 2020 06:16
vegarab pushed a commit to vegarab/nlp that referenced this pull request Aug 18, 2020
* add web_questions

* fix web questions dummy data

Co-authored-by: Mariama Drame <mariama@debmower_ajd>
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants