Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove print statements in datasets #3546

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Remove print statements in datasets #3546

merged 3 commits into from
Jan 7, 2022

Conversation

mariosasko
Copy link
Collaborator

@mariosasko mariosasko commented Jan 7, 2022 •
edited
Loading

This is a second time I'm removing print statements in our datasets, so I've added a test to avoid these issues in the future.

@mariosasko
Copy link
Collaborator Author

The CI failures are unrelated to the changes.

lhoestq
lhoestq approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mariosasko mariosasko merged commit 1766743 into master Jan 7, 2022
@mariosasko mariosasko deleted the remove-print-in-datasets branch January 7, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariosasko @lhoestq