Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IndoNLI dataset #3307

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Add IndoNLI dataset #3307

merged 3 commits into from
Nov 25, 2021

Conversation

afaji
Copy link
Contributor

@afaji afaji commented Nov 20, 2021

This PR adds IndoNLI dataset, from https://aclanthology.org/2021.emnlp-main.821/

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing thank you !
Good job with the dataset script and the dataset card for its comprehensiveness :)

My only comment is about the names of the labels. In my opinion it would be more practical to have the full names rather than the letters c, n or e for consistency and readability.

Once they're renamed you can regenerate the datasets_infos.json file and we should be all good !

datasets/indonli/indonli.py Outdated Show resolved Hide resolved
datasets/indonli/indonli.py Outdated Show resolved Hide resolved
@afaji
Copy link
Contributor Author

afaji commented Nov 24, 2021

@lhoestq thanks for the review! I've modified the labels to follow other NLI datasets.
Please review my change and let me know if I miss anything.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect thank you !

Merging now :)

@lhoestq lhoestq merged commit a46d8f5 into huggingface:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants