Deprecate prepare_module #3166
Merged
Deprecate prepare_module #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
commented
Oct 27, 2021
| module_path, hash, base_path, namespace = prepare_module( | ||
| path, | ||
| return_associated_base_path=True, | ||
| return_namespace=True, |
There was a problem hiding this comment.
@lhoestq could you please verify that this PR does not break this because of the parameter return_namespace?
Before this PR, this parameter no longer existed in the signature of prepare_module...
lhoestq
approved these changes
Oct 29, 2021
src/datasets/load.py
Outdated
| @@ -1263,13 +1263,18 @@ def prepare_module( | |||
| **download_kwargs, | |||
| ) -> Union[Tuple[str, str], Tuple[str, str, Optional[str]]]: | |||
| """For backward compatibility. Please use dataset_module_factory or metric_module_factory instead.""" | |||
| warnings.warn( | |||
| "'prepare_module' was superseded by 'dataset_module_factory' and 'metric_module_factory' in version 1.13 and " | |||
| "will be removed in version 1.15.", | |||
There was a problem hiding this comment.
1.15 will be the next release, maybe wait for 1.16 ?
Suggested change
| "will be removed in version 1.15.", | |
| "will be removed in version 1.16.", |
There was a problem hiding this comment.
@lhoestq, indeed, prepare_module was deprecated in 1.13 version, therefore +2 to be removed.
But I agree that we are making minor releases so often, that maybe we should change the rule to +3 or +4 or even to next major release!
|
Sounds good, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.13,
prepare_modulewas deprecated.This PR adds a deprecation warning and removes it from all the library, using
dataset_module_factoryormetric_module_factoryinstead.Fix #3165.