Correctly update metadata to preserve features when concatenating datasets with axis=1 #3120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly updates metadata to preserve higher-level feature types (e.g.
ClassLabel
) indatasets.concatenate_datasets
whenaxis=1
. Previously, we would delete the feature metadata indatasets.concatenate_datasets
ifaxis=1
and restore the feature types from the arrow table schema inDataset.__init__
. However, this approach only works for simple feature types (e.g.Value
).Fixes #3111