-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding adversarialQA dataset #1714
Adding adversarialQA dataset #1714
Conversation
Oh that's a really cool one, we'll review/merge it soon! In the meantime, do you have any specific positive/negative feedback on the process of adding a datasets Max? |
Thanks Thom, been a while, hope all is well! Yes, I followed the step by step instructions and found them pretty straightforward. The only things I wasn't sure of were what should go into the YAML tags field for the dataset card, and whether there was a list of options somewhere (maybe akin to the metrics?) of the possible supported tasks. I found the rest very intuitive and the automated metadata and dummy data generation very handy. Thanks! |
Good point! pinging @yjernite here so he can improve this part! |
@maxbartolo cool addition! For the YAML tag, you should use the tagging app we provide to choose from a drop-down menu: The process is described toward the end of the step-by-step guide, do you have any suggestions for making it easier to find? Otherwise, the dataset card is really cool, thanks for making it so complete! |
Thanks, YAML tags added. I think my main issue was with the flow of the step-by-step guide. For example, the card creator is introduced in Step 4, right after creating an empty directory for your dataset. The first field it requires are the YAML tags, which (at least for me) was the last step of the process. I'd suggest having the guide structured in the same order as the creation process. For me it was something like:
Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me !
Thank you for adding it :) and good dataset card as well
I just did one minor change in the dummy_data.zip files: I removed unused files to make them lighter.
* Adding adversarialQA dataset * Added YAML tags * reduce dummy_data.zip files sizes Co-authored-by: Quentin Lhoest <lhoest.q@gmail.com>
Adding the adversarialQA dataset (https://adversarialqa.github.io/) from Beat the AI (https://arxiv.org/abs/2002.00293)