Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): correct app.on(method,path[],middleware,handler) type #3802

Merged

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Jan 5, 2025

Fixes #3795

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

github-actions bot commented Jan 5, 2025

Bundle size check

main (5af7b4f) #3802 (14f5a24) +/-
Bundle Size (B) 18,771B 18,771B 0B
Bundle Size (KB) 18.33K 18.33K 0K

Compiler Diagnostics

main (5af7b4f) #3802 (14f5a24) +/-
Files 257 257 0
Lines 115,049 115,049 0
Identifiers 112,029 112,032 3
Symbols 243,515 243,516 1
Types 204,779 204,790 11
Instantiations 3,044,345 3,044,415 70
Memory used 424,343K 421,919K -2,424K
I/O read 0.03s 0.03s 0s
I/O write 0s 0s 0s
Parse time 0.77s 0.8s 0.03s
Bind time 0.34s 0.36s 0.02s
Check time 5.77s 5.39s -0.38s
Emit time 0s 0s 0s
Total time 6.88s 6.55s -0.33s

Reported by octocov

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (5af7b4f) to head (8bf4d5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3802   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         160      160           
  Lines       10195    10195           
  Branches     2856     2862    +6     
=======================================
  Hits         9350     9350           
  Misses        844      844           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe merged commit 100745a into main Jan 5, 2025
16 checks passed
@yusukebe yusukebe deleted the fix/types-app-on-method-paths-accepts-custom-context branch January 5, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware context extension doesn't work with app.on
1 participant