feat: minimal_mode for iframe embedding #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-feat: render minimal_mode version when url parameter is true -feat: remove hover listener (always keep visualization active) -style: remove box-shadow
-feat: add buttons for scrolling to top and bottom of navigation
-feat: add export buttons
|
Dominik to look at the docs |
-feat: intersection observer for hiding legend -style: styles for minimal mode buttons and spacing
-feat: reformat the linear view controls (add container) -style: adjut spacing of controls
-style: center controls only in minimal mode
-chore: adjust opacity calculation for legend -chore: update title for navigation buttons
sehilyi
reviewed
May 15, 2024
| @@ -747,3 +748,259 @@ a:hover { | |||
| opacity: 1; | |||
| background-color: #7aaded; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I see now that, since the gene search menu is in the middle, it occasionally overlaps with tooltips when I hover on an SV in the genome view. Making tooltips visible.
Suggested change
| .track-mouseover-menu { | |
| z-index: 999; | |
| } |
sehilyi
reviewed
May 15, 2024
Comment on lines
+328
to
+331
| const observer = new IntersectionObserver(entry => { | ||
| // Set intersection ratio as opacity (round up to one decimal place) | ||
| legendElement.style.opacity = '' + Math.ceil(10 * entry[0].intersectionRatio) / 10; | ||
| }, options); |
There was a problem hiding this comment.
I was not aware of IntersectionObserver which seems useful!
sehilyi
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal Mode version for the UI, to be integrated into other sites as iframes