Logger storage improvements #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are quite a few changes packed here, so I'll try to summarize: - Refactor the `ComponentNode` records into a simple `Node` class: This is important because we unlock a simpler mutability (no need to have atomic references), simpler creation (the only argument required is the component) and we remove the redundant control over updates (atomic references vs locks, in favour of locks). - Replace char[][] structure with a simple String Altough the original idea was to save memory by using char[][], it was actually much worse as proven by a few tests, so instead we work with strings natively. - Drop cursors in favour of StringNavigator The StringNavigator is an improvement over the Cursors as we can keep the search code local to the functions that require it. For the comparison of the components in a string we rely in the `StringNavigator` and the `StringView` classes, which create much less garbage. The `StringView` object just clips the original string by adding an offset based on `.` and `$` positions in the base string.
Note that there's a caveat in the JMH tests: If we store the context, the only actual test we'll be running is against a completely cached set of values, so we need to recreate the storage at each test to ensure we'll have a cance to test both creating new elements and fetching cached elements.
hkupty
force-pushed
the
logger-storage-improvements
branch
from
becde05 to
4a5afde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.