Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supervised packing with greedy knapsack algorithm #4009

Merged
merged 6 commits into from
Jun 6, 2024
Merged

supervised packing with greedy knapsack algorithm #4009

merged 6 commits into from
Jun 6, 2024

Conversation

AlongWY
Copy link
Contributor

@AlongWY AlongWY commented May 31, 2024

What does this PR do?

Fixes #2289
Fixes #3957

使用贪心背包算法进行 sft packing,不会抛掉样本

Before submitting

@hiyouga hiyouga added the pending This problem is yet to be addressed label May 31, 2024
@hiyouga hiyouga self-requested a review May 31, 2024 07:56
@AlongWY
Copy link
Contributor Author

AlongWY commented Jun 4, 2024

有什么理由不进行合并吗?

@hiyouga
Copy link
Owner

hiyouga commented Jun 4, 2024

已经在安排 review 了,需要时间测试正确性

Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did little modifications on the implementation, thanks for your contribution!

@hiyouga hiyouga merged commit 181dbb0 into hiyouga:main Jun 6, 2024
1 check passed
@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
2 participants