This repository has been archived by the owner on May 17, 2024. It is now read-only.
feat: configure default-network-opts mtu #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiashuste
force-pushed
the
use-default-network-opts
branch
from
8bce7d7 to
77e4d13
Compare
tobiashuste
force-pushed
the
use-default-network-opts
branch
from
77e4d13 to
44fdaf6
Compare
|
@Normo Could you please check this. I hope this helps to resolve the docker-compose MTU related issues. |
If an MTU lower than 1500 is present, docker-compose inside CI jobs can lead to issues as docker-compose always defaults to networks with an MTU of 1500. With this change a user should not be required to set the MTU on their own in docker-compose. Requires at least Docker 24.
tobiashuste
force-pushed
the
use-default-network-opts
branch
from
44fdaf6 to
ad2b268
Compare
Normo
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an MTU lower than 1500 is present, docker-compose inside CI jobs can lead to issues as docker-compose always defaults to networks with an MTU of 1500. With this change a user should not be required to set the MTU on their own in docker-compose.
Requires at least Docker 24.