Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Skip runner registration in molecule test run #14

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

tobiashuste
Copy link
Member

@tobiashuste tobiashuste commented Apr 13, 2022

This makes sure that the CI pipeline works for forks as well. Therefore it does this:

  • Skip runner registration verification in molecule test runs when the registration token is unset
  • Do not redownload the .deb file if the expected version is already installed
  • Download the deb file from packages.gitlab.com

Closes #9

@tobiashuste tobiashuste force-pushed the fix-forked-ci-pipeline branch 14 times, most recently from c4f7ca7 to 4be4795 Compare April 14, 2022 12:59
@tobiashuste tobiashuste marked this pull request as ready for review April 14, 2022 12:59
@tobiashuste tobiashuste force-pushed the fix-forked-ci-pipeline branch from 4be4795 to 96a2289 Compare April 14, 2022 13:07
@tobiashuste tobiashuste added the enhancement New feature or request label Apr 14, 2022
@tobiashuste tobiashuste self-assigned this Apr 14, 2022
@tobiashuste tobiashuste force-pushed the fix-forked-ci-pipeline branch from 96a2289 to 3d99951 Compare April 14, 2022 14:19
This makes sure that the CI pipeline works for forks as well where the
registration token is unset.
Up until now the package file was always downloaded even if the correct
version was already installed.
Download from the official GitLab location.
@tobiashuste tobiashuste force-pushed the fix-forked-ci-pipeline branch from 3d99951 to fbc9b4f Compare April 14, 2022 14:22
Copy link
Member

@christianhueserhzdr christianhueserhzdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Tobias @tobiashuste, from my point of view these changes are alright and the CI pipeline runs successfully. Thanks for fixing the pipeline for forked projects.

@tobiashuste tobiashuste merged commit fb1c027 into hifis-net:main Apr 14, 2022
@tobiashuste tobiashuste deleted the fix-forked-ci-pipeline branch April 14, 2022 17:20
@tobiashuste tobiashuste added this to the v0.6.0 milestone May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI pipeline in forks fails
3 participants