Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commandline parameter address to set the binding ip address (ipv4) #28

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Add commandline parameter address to set the binding ip address (ipv4) #28

merged 4 commits into from
Sep 20, 2023

Conversation

tobiashochguertel
Copy link
Contributor

@tobiashochguertel tobiashochguertel commented Sep 19, 2023

new Commandline parameter address short -a


For the Pull Request to be accepted please check:

  • The PR has a meaningful title.
  • If the PR refers to an issue, it should be referenced with the GitHub format (#ID).
  • The PR is done to the develop branch (new features) or the master branch (releases).
  • The code pass all PR checks.
  • All public members are documented using KDoc.
  • The code follow the coding conventions stated at the contributing.md file.

@jaguililla jaguililla merged commit 9ea473c into hexagontk:develop Sep 20, 2023
@jaguililla
Copy link
Member

Closes #27 and also closes #29. Thanks @tobiashochguertel!

@tobiashochguertel
Copy link
Contributor Author

Closes #27 and also closes #29. Thanks @tobiashochguertel!

Doesn't close #29, for that, I wanted to create a new pull request when this pull request is merged. I thought that are two things, so I created two issues and two pull requests. Next time I should create two feature branches.

brb. I create the next pull request.

@tobiashochguertel
Copy link
Contributor Author

Closes #27 and also closes #29. Thanks @tobiashochguertel!

Doesn't close #29, for that, I wanted to create a new pull request when this pull request is merged. I thought that are two things, so I created two issues and two pull requests. Next time I should create two feature branches.

brb. I create the next pull request.

Ooops... okay, I thought that a pull request only reflects the commits from the time when I created the p-request. 🤦‍♂️

@jaguililla
Copy link
Member

No worries... Is it OK then? or do I have to change something? Just let me know if you need something 🙂

@tobiashochguertel
Copy link
Contributor Author

No worries... Is it OK then? or do I have to change something? Just let me know if you need something 🙂

Thanks, no everything is okay from my side. If I have time in this night, I will try to work on #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants