Raise cache reload timeout limit #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKaemmerling
approved these changes
Sep 5, 2022
|
Greetings from 🇮🇹 looks fine but please add a comment why you changed it |
|
@LKaemmerling Greetings back from DE :-) I updated the PR description! Have a nice holiday! |
|
Thats great , could someone say when the fix will be released ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update the internal cache, the provider is getting all servers of the corresponding project / user. For that, the /servers endpoint is called with page max page size of 50 per call.
But there is an internal timeout of 5s for that calls. And right now, if there is a user with more than 50+ server, one call need more time than 5s.
As a quick fix, we raise the timeout. Internally, we get enough time to investigate more consistent optimizations in API or in the controller manager cache handling.