Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move config.ini to config.example to make upgrades easier. #163

Merged
merged 7 commits into from
May 28, 2024

Conversation

stlorenz
Copy link
Contributor

I have renamed the example config to config.example and updated the doc accordingly.
With that change, an update does not overwrite the existing config.ini

Update .gitignore and README.md files

@dsteinkopf
Copy link
Collaborator

I like this!

@stlorenz
Copy link
Contributor Author

stlorenz commented Apr 25, 2024

I did not want to propose too many changes in my first contribution but when this gets accepted, the installation/upgrade process could be restructured like this:
Install:

cd /data/
git clone reponame
cd dbus-opendtu/
mv config.example config.ini 
vi config.ini 
./install.sh

and then upgrade would work that way:

git add . 
git commit -m "preserve config"
git pull
./restart.sh

@henne49
Copy link
Owner

henne49 commented Apr 27, 2024

@0x7878 we still have the Versioning failing, can you check in the github action

@0x7878
Copy link
Collaborator

0x7878 commented Apr 27, 2024

@0x7878 we still have the Versioning failing, can you check in the github action

See #164 but either we have to configure a secured way to this or we have to drop this feature.

@stlorenz
Copy link
Contributor Author

stlorenz commented May 2, 2024

See #164 but either we have to configure a secured way to this or we have to drop this feature.

Is there something I need to do?

@0x7878
Copy link
Collaborator

0x7878 commented May 3, 2024

@stlorenz don't worry. It's just us. We have to improve our GitHub Actions. That's all. We need more time to get it done.

@0x7878
Copy link
Collaborator

0x7878 commented May 27, 2024

If you push something to this repo, the error should go away and we can merge this.

@stlorenz
Copy link
Contributor Author

done.

@dsteinkopf
Copy link
Collaborator

Look good to me.

@dsteinkopf dsteinkopf requested review from henne49 and dsteinkopf May 27, 2024 19:09
Copy link
Owner

@henne49 henne49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks very good, ready to merge

@henne49 henne49 requested a review from dsteinkopf May 28, 2024 06:43
@henne49 henne49 merged commit 632447f into henne49:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants