Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BrowserAnimationsModule to NoopAnimationsModule #641

Closed
satanTime opened this issue Jun 3, 2021 · 5 comments · Fixed by #644
Closed

BrowserAnimationsModule to NoopAnimationsModule #641

satanTime opened this issue Jun 3, 2021 · 5 comments · Fixed by #644
Labels
released v12.1.0

Comments

@satanTime
Copy link
Member

satanTime commented Jun 3, 2021 •
edited
Loading

need a transparent way how to replace BrowserAnimationsModule if it hasn't been provided explicitly.
@satanTime
Copy link
Member Author

Hi @Dji75,

could you verify that this version works for your without the global exclusion of animations?

ng-mocks.zip

Thank you in advance!

@satanTime satanTime mentioned this issue Jun 3, 2021
Merged
satanTime added a commit that referenced this issue Jun 3, 2021
@satanTime
feat(core): replacing animations with noop by default #641
ca65de3
satanTime added a commit that referenced this issue Jun 3, 2021
@satanTime
Merge pull request #644 from satanTime/issues/641
520a60d 
feat(core): replacing animations with noop by default #641
@Dji75
Copy link
Contributor

Dji75 commented Jun 4, 2021

Hi @satanTime,

Yes it worked ! ;)

I can now get rid of this, thanks ! :)

ngMocks.globalReplace(BrowserAnimationsModule, NoopAnimationsModule);

@satanTime
Copy link
Member Author

Cool. Thanks! Sunday is the release day then :)

@satanTime
Copy link
Member Author

v12.1.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

@Dji75
Copy link
Contributor

Dji75 commented Jun 7, 2021

It works like a charm, thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released v12.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): replacing animations with noop by default #641 satanTime/ng-mocks
2 participants
@satanTime @Dji75