Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: hide public exports of isNgModuleDefWithProviders #2173

Closed
satanTime opened this issue Apr 3, 2022 · 1 comment · Fixed by #2174
Closed

Bug: hide public exports of isNgModuleDefWithProviders #2173

satanTime opened this issue Apr 3, 2022 · 1 comment · Fixed by #2174
Assignees
@satanTime
Labels
bug Something isn't working released v13.4.0

Comments

@satanTime
Copy link
Member

Description of the bug

isNgModuleDefWithProviders is exposed, and can be wrongly imported instead of ModuleWithProviders from @angular/core.

Expected vs actual behavior

isNgModuleDefWithProviders isn't exported.
@satanTime satanTime added the bug Something isn't working label Apr 3, 2022
@satanTime satanTime self-assigned this Apr 3, 2022
satanTime added a commit to satanTime/ng-mocks that referenced this issue Apr 3, 2022
@satanTime
fix(core): removing isNgModuleDefWithProviders from exports help-me-m…
7501dc9 
…om#2173
@satanTime satanTime mentioned this issue Apr 3, 2022
Merged
satanTime added a commit that referenced this issue Apr 3, 2022
@satanTime
Merge pull request #2174 from satanTime/issues/2173
9597636 
fix(core): removing isNgModuleDefWithProviders from exports #2173
@satanTime
Copy link
Member Author

v13.4.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satanTime satanTime

Labels
bug Something isn't working released v13.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): removing isNgModuleDefWithProviders from exports #2173 satanTime/ng-mocks
1 participant
@satanTime