Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/envoy] Fix typo for envoy #23258

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[stable/envoy] Fix typo for envoy #23258

merged 2 commits into from
Jul 21, 2020
+2 −2

Conversation

renjikari
Copy link
Contributor

@renjikari renjikari commented Jul 20, 2020 •
edited
Loading

Is this a new chart

No

What this PR does / why we need it:

Fix my #18878 typo
from lifecyle to lifecycle

Which issue this PR fixes

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

renjikari added 2 commits July 20, 2020 16:22
@renjikari
Fix typo
4de4b42 
Signed-off-by: Shunki Fujiwara <shunki-fujiwara@freee.co.jp>
@renjikari
Bump minor version
632728f 
Signed-off-by: Shunki Fujiwara <shunki-fujiwara@freee.co.jp>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2020
@k8s-ci-robot k8s-ci-robot requested a review from mumoshu July 20, 2020 07:26
@k8s-ci-robot
Copy link
Contributor

Hi @renjikari. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2020
@renjikari
Copy link
Contributor Author

@mumoshu
I fix my old typo. It's pointed out in #18878
Would you mind reviewing?

mumoshu
mumoshu approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mumoshu
Copy link
Collaborator

mumoshu commented Jul 21, 2020

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2020
@mumoshu
Copy link
Collaborator

mumoshu commented Jul 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mumoshu, renjikari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 740cede into helm:master Jul 21, 2020
@renjikari renjikari mentioned this pull request Jul 21, 2020
Merged
4 tasks
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@renjikari @li-adrienloiseau
[stable/envoy] Fix typo for envoy (helm#23258)
5247aff 
* Fix typo

Signed-off-by: Shunki Fujiwara <shunki-fujiwara@freee.co.jp>

* Bump minor version

Signed-off-by: Shunki Fujiwara <shunki-fujiwara@freee.co.jp>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@renjikari
[stable/envoy] Fix typo for envoy (helm#23258)
5eb5198 
* Fix typo

Signed-off-by: Shunki Fujiwara <shunki-fujiwara@freee.co.jp>

* Bump minor version

Signed-off-by: Shunki Fujiwara <shunki-fujiwara@freee.co.jp>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renjikari @k8s-ci-robot @mumoshu @helm-bot