Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Update Controller image registry to .gcr.io #23213

Merged
merged 1 commit into from
Jul 18, 2020
Merged

[stable/nginx-ingress] Update Controller image registry to .gcr.io #23213

merged 1 commit into from
Jul 18, 2020

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jul 16, 2020

Is this a new chart

No

What this PR does / why we need it:

The repository https://quay.io/repository/kubernetes-ingress-controller/nginx-ingress-controller is deprecated and read-only for historical purposes.
See /~https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v0.34.0

Which issue this PR fixes

#23152

Special notes for your reviewer:

The following have been tested:

  • No registry mentioned but the repository is mentioned
  • Both registry and repository are mentioned
  • The image digest is mentioned
  • The image digest is not mentioned but image tag is mentioned
    cc: @ChiefAlexander @taharah

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @a7i. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2020
@ChiefAlexander
Copy link
Collaborator

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2020
@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2020
@a7i
Update NGINX Controller image registry to .gcr.io
1c6c9e6 
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Update app version to match docker image tag

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Fix controller image for daemonset

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@a7i
Copy link
Contributor Author

a7i commented Jul 17, 2020

/retest

@davidkarlsen
Copy link
Member

/assign
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i, ChiefAlexander, davidkarlsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 69df60c into helm:master Jul 18, 2020
@a7i a7i deleted the bugfix/23152 branch July 18, 2020 01:48
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@a7i @includerandom
Update NGINX Controller image registry to .gcr.io (helm#23213)
23a0a7a 
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Update app version to match docker image tag

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Fix controller image for daemonset

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
KinsheX pushed a commit to KinsheX/charts that referenced this pull request Jul 20, 2020
@a7i @KinsheX
Update NGINX Controller image registry to .gcr.io (helm#23213)
272303c 
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Update app version to match docker image tag

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Fix controller image for daemonset

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@a7i @li-adrienloiseau
Update NGINX Controller image registry to .gcr.io (helm#23213)
10600fc 
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Update app version to match docker image tag

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Fix controller image for daemonset

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@a7i
Update NGINX Controller image registry to .gcr.io (helm#23213)
0741b27 
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Update app version to match docker image tag

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>

Fix controller image for daemonset

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@taharah taharah Awaiting requested review from taharah

Assignees

@davidkarlsen davidkarlsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a7i @k8s-ci-robot @ChiefAlexander @davidkarlsen @helm-bot