Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/datadog] Support custom check definitions for CLC Runners #23139

Merged
merged 1 commit into from
Jul 27, 2020
Merged

[stable/datadog] Support custom check definitions for CLC Runners #23139

merged 1 commit into from
Jul 27, 2020

Conversation

juliogreff
Copy link
Contributor

What this PR does / why we need it:

It's already possible to define checksd and confd in the Agent
config, but those options are missing for the Clusterchecks Runner.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot requested a review from L3n41c July 9, 2020 14:10
@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @juliogreff. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2020
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2020
juliogreff added a commit to DataDog/datadog-operator that referenced this pull request Jul 16, 2020
@juliogreff
Propagate custom check definitions to CLC Runners
208a88a 
It's already possible to define `.Spec.Agent.Config.Confd` and
`.Spec.Agent.Config.Checksd`, but those options are not propagated to
the Clusterchecks Runner. As a runner is basically an agent, we're just
reusing the same configuration.

This applies the same changes as this proposed change to
stable/datadog's Helm chart: helm/charts#23139
@juliogreff juliogreff mentioned this pull request Jul 16, 2020
Merged
juliogreff added a commit to DataDog/datadog-operator that referenced this pull request Jul 17, 2020
@juliogreff
Propagate custom check definitions to CLC Runners
ed4f6b0 
It's already possible to define `.Spec.Agent.Config.Confd` and
`.Spec.Agent.Config.Checksd`, but those options are not propagated to
the Clusterchecks Runner. As a runner is basically an agent, we're just
reusing the same configuration.

This applies the same changes as this proposed change to
stable/datadog's Helm chart: helm/charts#23139
juliogreff added a commit to DataDog/datadog-operator that referenced this pull request Jul 17, 2020
@juliogreff
Propagate custom check definitions to CLC Runners
49f9d54 
It's already possible to define `.Spec.Agent.Config.Checksd`, but that
option is not propagated to the Clusterchecks Runner. As a runner is
basically an agent, we're just reusing the same configuration.

This applies the same changes as this proposed change to
stable/datadog's Helm chart: helm/charts#23139
juliogreff added a commit to DataDog/datadog-operator that referenced this pull request Jul 17, 2020
@juliogreff
Propagate custom check definitions to CLC Runners
ed7289a 
It's already possible to define `.Spec.Agent.Config.Checksd`, but that
option is not propagated to the Clusterchecks Runner. As a runner is
basically an agent, we're just reusing the same configuration.

This applies the same changes as this proposed change to
stable/datadog's Helm chart: helm/charts#23139
juliogreff added a commit to DataDog/datadog-operator that referenced this pull request Jul 17, 2020
@juliogreff
Propagate custom check definitions to CLC Runners
8c1aaee 
It's already possible to define `.Spec.Agent.Config.Checksd`, but that
option is not propagated to the Clusterchecks Runner. As a runner is
basically an agent, we're just reusing the same configuration.

This applies the same changes as this proposed change to
stable/datadog's Helm chart: helm/charts#23139
juliogreff added a commit to DataDog/datadog-operator that referenced this pull request Jul 17, 2020
@juliogreff
Propagate custom check definitions to CLC Runners
72b714c 
It's already possible to define `.Spec.Agent.Config.Checksd`, but that
option is not propagated to the Clusterchecks Runner. As a runner is
basically an agent, we're just reusing the same configuration.

This applies the same changes as this proposed change to
stable/datadog's Helm chart: helm/charts#23139
@L3n41c
Copy link
Collaborator

L3n41c commented Jul 24, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2020
@juliogreff
[stable/datadog] Propagate custom check definitions to CLC Runners
2ca70d1 
It's already possible to define `checksd` and in the Agent config, but
those options are not propagated to the Clusterchecks Runner. As a
runner is basically an agent, we're just reusing the same configuration.

Signed-off-by: Julio Greff <julio.greff@datadoghq.com>
@L3n41c
Copy link
Collaborator

L3n41c commented Jul 27, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliogreff, L3n41c

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 13d9e69 into helm:master Jul 27, 2020
@juliogreff juliogreff deleted the juliogreff/clc-runner-custom-check branch July 27, 2020 08:55
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@juliogreff @li-adrienloiseau
[stable/datadog] Propagate custom check definitions to CLC Runners (h…
dd74db7 
…elm#23139)

It's already possible to define `checksd` and in the Agent config, but
those options are not propagated to the Clusterchecks Runner. As a
runner is basically an agent, we're just reusing the same configuration.

Signed-off-by: Julio Greff <julio.greff@datadoghq.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
juliogreff added a commit to DataDog/datadog-operator that referenced this pull request Aug 4, 2020
@juliogreff
Propagate custom check definitions to CLC Runners
fe75253 
It's already possible to define `.Spec.Agent.Config.Checksd`, but that
option is not propagated to the Clusterchecks Runner. As a runner is
basically an agent, we're just reusing the same configuration.

This applies the same changes as this proposed change to
stable/datadog's Helm chart: helm/charts#23139
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@juliogreff
[stable/datadog] Propagate custom check definitions to CLC Runners (h…
a6850c8 
…elm#23139)

It's already possible to define `checksd` and in the Agent config, but
those options are not propagated to the Clusterchecks Runner. As a
runner is basically an agent, we're just reusing the same configuration.

Signed-off-by: Julio Greff <julio.greff@datadoghq.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@L3n41c L3n41c Awaiting requested review from L3n41c

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliogreff @k8s-ci-robot @L3n41c @helm-bot