This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/jenkins] Reorder README parameters into sections for readability #22782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
wmcdona89
force-pushed
the
refactor-readme
branch
from
378fca2 to
f3583d4
Compare
|
/assign @torstenwalter |
|
/retest |
There was a problem hiding this comment.
@wmcdona89 Thanks for suggesting this! It looks really good! One idea would be to split the table into multiple ones and use section titles as subheadings or keep it in one table and make those bold?
|
Testing infra was fixed, so last failure shouldn't happen again |
|
Try retest after resolving merge conflict |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
wmcdona89
force-pushed
the
refactor-readme
branch
from
f3583d4 to
e0b7ffa
Compare
helm-bot
removed
the
Contribution Allowed
stale
bot
removed
the
lifecycle/stale
wmcdona89
force-pushed
the
refactor-readme
branch
from
e0b7ffa to
91f363e
Compare
helm-bot
added
the
Contribution Allowed
wmcdona89
force-pushed
the
refactor-readme
branch
from
91f363e to
61074d2
Compare
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
wmcdona89
force-pushed
the
refactor-readme
branch
from
61074d2 to
0d8e3b3
Compare
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
wmcdona89
force-pushed
the
refactor-readme
branch
from
0d8e3b3 to
d2c722c
Compare
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
wmcdona89
force-pushed
the
refactor-readme
branch
from
d2c722c to
00c307a
Compare
helm-bot
removed
the
Contribution Allowed
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
wmcdona89
force-pushed
the
refactor-readme
branch
from
dd549c2 to
0ecf73f
Compare
helm-bot
added
the
Contribution Allowed
|
@torstenwalter this is ready for another review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torstenwalter, wmcdona89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
includerandom
pushed a commit
to includerandom/helm_charts
that referenced
this pull request
Jul 19, 2020
…ity (helm#22782) * [stable/jenkins] Reorder README parameters into sections for readability Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Chart's Primary Parameters Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration Files & Scripts Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Deployment & Service Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Secret Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Security Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Settings Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins In-Process Script Approval Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Plugins Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Kubernetes Plugin Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Top-Level Agent Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Pod Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Side Container Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * split sections into separate tables Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration as Code Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Deprecated Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
KinsheX
pushed a commit
to KinsheX/charts
that referenced
this pull request
Jul 20, 2020
…ity (helm#22782) * [stable/jenkins] Reorder README parameters into sections for readability Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Chart's Primary Parameters Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration Files & Scripts Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Deployment & Service Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Secret Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Security Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Settings Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins In-Process Script Approval Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Plugins Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Kubernetes Plugin Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Top-Level Agent Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Pod Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Side Container Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * split sections into separate tables Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration as Code Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Deprecated Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
li-adrienloiseau
pushed a commit
to li-adrienloiseau/charts
that referenced
this pull request
Jul 29, 2020
…ity (helm#22782) * [stable/jenkins] Reorder README parameters into sections for readability Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Chart's Primary Parameters Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration Files & Scripts Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Deployment & Service Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Secret Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Security Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Settings Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins In-Process Script Approval Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Plugins Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Kubernetes Plugin Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Top-Level Agent Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Pod Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Side Container Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * split sections into separate tables Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration as Code Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Deprecated Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
…ity (helm#22782) * [stable/jenkins] Reorder README parameters into sections for readability Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Chart's Primary Parameters Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration Files & Scripts Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Deployment & Service Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Secret Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Security Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Settings Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins In-Process Script Approval Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Plugins Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Kubernetes Plugin Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Top-Level Agent Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Pod Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Side Container Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * split sections into separate tables Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration as Code Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Deprecated Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
wmcdona89
added a commit
to wmcdona89/charts
that referenced
this pull request
Aug 30, 2020
…ity (helm#22782) * [stable/jenkins] Reorder README parameters into sections for readability Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Chart's Primary Parameters Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration Files & Scripts Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Deployment & Service Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Kubernetes Secret Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Security Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Global Settings Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins In-Process Script Approval Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Plugins Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Kubernetes Plugin Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Top-Level Agent Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Pod Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Agent Side Container Configuration Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * split sections into separate tables Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Jenkins Configuration as Code Signed-off-by: Aaron McDonald <wmcdona89@gmail.com> * Deprecated Signed-off-by: Aaron McDonald <wmcdona89@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reorder parameters in README to facilitate chart usage and maintenance.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
There are a series of commits to facilitate the review.
values.yamlcould also be reordered.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])