Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint values files in ci directory #66

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

jlegrone
Copy link
Member

@jlegrone jlegrone commented Dec 14, 2018

What this PR does / why we need it:

What it says on the tin. 😄I figure it would be best to lint all the values files we know about.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

This introduces 9 new errors for the stable charts:

$ ct lint --chart-dirs=stable --all | grep ✖︎
 ✖︎ stable/ethereum > Error waiting for process: exit status 1
 ✖︎ stable/keycloak > Error waiting for process: exit status 1
 ✖︎ stable/kibana > Error waiting for process: exit status 1
 ✖︎ stable/metrics-server > Error waiting for process: exit status 1
 ✖︎ stable/minecraft > Error waiting for process: exit status 1
 ✖︎ stable/mission-control > Error waiting for process: exit status 1
 ✖︎ stable/prometheus-operator > Error waiting for process: exit status 1
 ✖︎ stable/sumologic-fluentd > Error waiting for process: exit status 1
 ✖︎ stable/xray > Error waiting for process: exit status 1

@jlegrone
Copy link
Member Author

/assign @unguiculus

@jlegrone jlegrone force-pushed the feature/lint-ci-values branch from 359ea28 to d7e9732 Compare December 15, 2018 05:27
@helm-bot helm-bot added size/S and removed size/S labels Dec 15, 2018
Signed-off-by: Jacob LeGrone <git@jacob.work>
@jlegrone jlegrone force-pushed the feature/lint-ci-values branch from d7e9732 to 84dcdfd Compare December 17, 2018 21:50
@helm-bot helm-bot added size/S and removed size/S labels Dec 17, 2018
@unguiculus unguiculus merged commit 3ce597a into helm:master Dec 18, 2018
@jlegrone jlegrone deleted the feature/lint-ci-values branch December 18, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants